test: Enable App Launch Profiling UI tests #3665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The with GH-3529 added test method writeProfileFile crashed when a profile file already existed. Now, the writeProfileFile method exists and prints a debug message when a profiling file already exists and logs an error when it can't write the profile.
The UI tests in SauceLabs frequently time out. Let's increase the value to 60m, as it's better to have delayed UI test results than failing CI.
Downloading the jUnit artifacts fails frequently, and we don't use them. Therefore, we can remove them.
Enable the app launch profiling UI tests again to ensure the feature works correctly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3665 +/- ##
=============================================
- Coverage 89.277% 89.261% -0.016%
=============================================
Files 534 534
Lines 58977 58977
Branches 21165 21164 -1
=============================================
- Hits 52653 52644 -9
- Misses 5289 5298 +9
Partials 1035 1035 see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Replace running UI tests in SauceLabs with GH actions because SauceLabs tests are unreliable; see internal Notion decision.
…nch-profiling-tests
philipphofmann
changed the base branch from
main
to
ci/move-ui-tests-to-gh-simulators
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1d11695 | 1219.57 ms | 1243.52 ms | 23.95 ms |
| c0c1496 | 1201.19 ms | 1228.36 ms | 27.17 ms |
| b9d59f7 | 1250.71 ms | 1257.78 ms | 7.06 ms |
| be2977c | 1243.94 ms | 1258.59 ms | 14.65 ms |
| 98752f3 | 1226.18 ms | 1251.38 ms | 25.20 ms |
| 28c80b5 | 1198.63 ms | 1214.08 ms | 15.45 ms |
| 2b55154 | 1231.36 ms | 1247.82 ms | 16.46 ms |
| 4259afd | 1234.04 ms | 1256.76 ms | 22.72 ms |
| 0f30019 | 1239.22 ms | 1240.04 ms | 0.82 ms |
| 3437454 | 1235.54 ms | 1244.82 ms | 9.28 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1d11695 | 20.76 KiB | 401.60 KiB | 380.84 KiB |
| c0c1496 | 22.85 KiB | 407.45 KiB | 384.60 KiB |
| b9d59f7 | 22.85 KiB | 405.77 KiB | 382.93 KiB |
| be2977c | 22.85 KiB | 407.67 KiB | 384.82 KiB |
| 98752f3 | 20.76 KiB | 435.09 KiB | 414.33 KiB |
| 28c80b5 | 21.58 KiB | 417.85 KiB | 396.27 KiB |
| 2b55154 | 22.84 KiB | 402.19 KiB | 379.34 KiB |
| 4259afd | 20.76 KiB | 419.70 KiB | 398.94 KiB |
| 0f30019 | 22.84 KiB | 405.39 KiB | 382.54 KiB |
| 3437454 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
philipphofmann
requested review from
brustolin and
armcknight
as code owners
brustolin
approved these changes
Feb 20, 2024
philipphofmann
added a commit
that referenced
this pull request
Feb 20, 2024
GH-3665 didn't enable the app launch profiling tests because they were still disable in Xcode. This PR fixes that and also uses more accessibility identifiers in the profiling tests.
philipphofmann
added a commit
that referenced
this pull request
Feb 22, 2024
GH-3665 didn't enable the app launch profiling tests because they were still disabled in Xcode. This PR fixes that and also uses more accessibility identifiers in the profiling tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the app launch profiling UI tests again to ensure the feature works correctly.
This PR is based on #3666.
#skip-changelog